Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/disable django-check-seo on a per user basis #53

Open
jgadelange opened this issue Sep 13, 2022 · 3 comments
Open

Enable/disable django-check-seo on a per user basis #53

jgadelange opened this issue Sep 13, 2022 · 3 comments

Comments

@jgadelange
Copy link
Contributor

Is your feature request related to a problem? Please describe.
For some of our clients we would like to be able to disable django-check-seo for them, but have it available to ourselves.

Describe the solution you'd like
I would like to add a permission in the default django user admin that we can give to the users/groups that should be able to view the django-check-seo page. I believe the current behaviour should also be supported (only staff users can view the page), therefore I think we can add a setting (e.g. DJANGO_CHECK_SEO_USE_PERMISSIONS) that toggles the behaviour.

Describe alternatives you've considered
N/A

Additional context
In the future we probably also want be able to have access control on a per check basis (so not show all checks to every user), so that could be something that could be considered while implementing this feature.

@corentinbettiol
Copy link
Member

Hi!

I added a new permission in django check seo 1.0.0 :)

@jgadelange
Copy link
Contributor Author

I think we should should also remove django-check-seo from the cms menu: https://github.com/kapt-labs/django-check-seo/blob/master/django_check_seo/cms_toolbars.py#L16

@corentinbettiol
Copy link
Member

True.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants