Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DJANGO_CHECK_SEO_EXCLUDE_CONTENT does not exclude content in conditional comments #44

Open
adrien-delhorme opened this issue May 19, 2021 · 0 comments
Open

DJANGO_CHECK_SEO_EXCLUDE_CONTENT does not exclude content in conditional comments #44

adrien-delhorme opened this issue May 19, 2021 · 0 comments

Comments

@adrien-delhorme
Copy link
Member

adrien-delhorme commented May 19, 2021 •
edited
Loading

Describe the bug
The content inside html conditional comments is not excluded even though it is referenced in DJANGO_CHECK_SEO_EXCLUDE_CONTENT setting.

To Reproduce
Steps to reproduce the behavior:

Considering the following template:

<body>
  <!--[if lt IE 8]>
    <p class="catch-me-if-you-can"></p>
  <![endif]-->
</body>
  1. Add DJANGO_CHECK_SEO_EXCLUDE_CONTENT = ".catch-me-if-you-can" in your settings
  2. Click on "Check SEO" toolbar button
  3. Check the "Raw data" section
  4. See that .catch-me-if-you-can HTML tag is not excluded

Expected behavior
.catch-me-if-you-can HTML tag is excluded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adrien-delhorme