[SR-1397] Incorporate unused 0.8.2 improvements #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Ensure we wind to beginning of business day when using business_hours before/after methods
Fixes for issues bokmann#36, bokmann#45 and bokmann#83 (bug in business_days.before/after)
Add examples for `#workday?`
Update bundler before travis builds
…ss_days_until Adds support for inclusive results from business_days_until() method
I love this feature! Why didn't I know this existed before?
I didn't really need to do this, but it served as a useful example.
Really, I'm just testing to see if the git status hooks actually do something useful.
Updates Activesupport version and internal version prepping for release.
When you use Time.parse, you get a Time object back; when you use Time.zone.parse, you get a TimeWithZone. The code should preserve the timezone _on this time object_, not re-apply Time.zone, which can change independently of time objects. Added to the misnamed business_time_until_eastern test to demonstrate that timezone is preserved in both Time and TimeWithZone objects; fixed a failing test in test_calculating_business_duration that wrongly assumed that Time.parse objects should follow Time.zone.
Fix timezone inconsistencies
…PT-3440-merge-official-develop Conflicts: Gemfile.lock business_time.gemspec lib/business_time/business_days.rb lib/business_time/core_ext/date.rb lib/business_time/version.rb test/test_business_time_until_eastern.rb
Feature/pt 3440 merge official develop
Already done at test_helper
…oading Parse holidays on config loading
…ment' into feature/SR-0000-incorporate-0.8-2-improvements
Base automatically changed from
feature/SR-1396-add-ci-and-loosen-activesupport-requirement
to
0-8-stable
June 27, 2024 15:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SR-1397