Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cli package with envconfig parser #7

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add cli package with envconfig parser #7

wants to merge 3 commits into from

Conversation

colinhoglund
Copy link
Member

This adds a new cli package and adds an initial EnvconfigProcessWithPflags function that can be used to run envconfig.Process without stomping on flags passed to the command line, since explicit flags should take precedence over the environment.

@colinhoglund colinhoglund requested a review from dskatz February 11, 2025 21:32
@colinhoglund colinhoglund marked this pull request as draft February 11, 2025 21:33
@colinhoglund colinhoglund removed the request for review from dskatz February 11, 2025 21:33
@colinhoglund colinhoglund deleted the add_cli_pkg branch February 11, 2025 21:34
@colinhoglund colinhoglund restored the add_cli_pkg branch February 11, 2025 21:38
@colinhoglund colinhoglund reopened this Feb 11, 2025
@colinhoglund colinhoglund marked this pull request as ready for review February 11, 2025 21:40
@colinhoglund colinhoglund requested a review from dskatz February 11, 2025 21:40
dskatz
dskatz previously approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@dskatz dskatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some go.mod conflicts.

@colinhoglund colinhoglund requested a review from dskatz February 14, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dskatz dskatz Awaiting requested review from dskatz

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colinhoglund @dskatz