bug: sort inline properties recusively to prevent flaky struct field order #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hidetatz
commented
Oct 1, 2024
hidetatz
changed the title
hidetatz
force-pushed
the
hidetatz/fix-prop-sort
branch
from
8a283f3
to
f252a39
Compare
|
At a glance, it seems that this line can be removed, but everything else looks good 🙏 Line 272 in f252a39 |
hidetatz
force-pushed
the
hidetatz/fix-prop-sort
branch
from
f252a39
to
5fd8e8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case a resource contains another resource, it is set to
InlineProperties. This InlineProperties is also a Property, so this can nest infinitely.This PR introduces recursive property sort. Without this, nested properties are not sorted, so suppose "an object of an array of an object..." is not sorted.