Replace FileOutputStream by nio Files.newOutputStream and Channels.newOutputStream #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wOutputStream FileOutputStream contains a finalizer which can cause excessive garbage collector pressure when writing many TAR files. Finalizers are only executed when the GC feels like it. Until they are executed, objects with finalizers are not garbage collected. Internal benchmarks have shown that hundreds of thousands of FileOutputStream objects could remain in memory for a very long time as a result. This patch reduces GC pressure.
liyujiang-gzu
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch reduces GC pressure.
FileOutputStream contains a finalizer which can cause excessive garbage
collector pressure when writing many TAR files.
Finalizers are only executed when the GC feels like it. Until they are
executed, objects with finalizers are not garbage collected. Internal
benchmarks have shown that hundreds of thousands of FileOutputStream
objects could remain in memory for a very long time as a result.
We've been using this internally for a few months, without any issues.