Skip to content

Commit

Permalink
Fixes in opening packages
Browse files Browse the repository at this point in the history
  • Loading branch information
kam193 committed Apr 14, 2024
1 parent 9f81454 commit e5524a0
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 16 deletions.
4 changes: 4 additions & 0 deletions common.mk
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,11 @@ run-with-updates: run
run-with-external: CONTAINER_NETWORK=external
run-with-external: run

pull-base:
docker pull ${BASE_IMAGE}

refresh: CACHE="--no-cache"
refresh: pull-base
refresh: build

run-dep: CONTAINER_NETWORK=external
Expand Down
2 changes: 1 addition & 1 deletion python-magic/VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
5
7
1 change: 0 additions & 1 deletion python-magic/service/extract/pycdc.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import os
import re
import shutil
import subprocess

from assemblyline_v4_service.common.result import ResultTextSection
Expand Down
8 changes: 2 additions & 6 deletions python-magic/service/package/analyzer.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,19 +58,15 @@ def analyze(self):

scripts = opener.get_console_scripts()
if scripts:
script_section = ResultTextSection(
"Console scripts", auto_collapse=True
)
script_section = ResultTextSection("Console scripts", auto_collapse=True)
script_section.add_line("This package declares following console scripts:")
for script in scripts:
script_section.add_line(script)
section.add_subsection(script_section)

top_level_modules = opener.get_top_level_modules()
if top_level_modules:
module_section = ResultTextSection(
"Top-level modules", auto_collapse=True
)
module_section = ResultTextSection("Top-level modules", auto_collapse=True)
module_section.add_line("This package declares following top-level modules:")
for module in top_level_modules:
module_section.add_line(module)
Expand Down
16 changes: 11 additions & 5 deletions python-magic/service/package/opener.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import configparser
import tarfile
import zipfile
from contextlib import suppress
from functools import lru_cache
from itertools import chain

Expand Down Expand Up @@ -86,18 +87,23 @@ def get_package_name(self) -> str:

def get_console_scripts(self):
if entry_points := self.get_distribution_file("entry_points.txt"):
parser = CaseSensitiveConfigParser()
parser.read_string(entry_points)
return (k for k, _ in parser.items("console_scripts"))
with suppress(configparser.Error):
parser = CaseSensitiveConfigParser()
parser.read_string(entry_points)
return (k for k, _ in parser.items("console_scripts"))
return []

def get_requirements(self):
required = set()
for req in chain(self.distribution.requires, self.distribution.requires_dist):
requires_txt = []
if requirements := self.get_distribution_file("requires.txt"):
requires_txt = requirements.splitlines()
for req in chain(self.distribution.requires, self.distribution.requires_dist, requires_txt):
if any(op in req for op in ("<", ">", "=", " ")):
for op in ("<", ">", "!", "~", "=", " "):
req = req.split(op, 1)[0]
required.add(req.strip())
if req:
required.add(req.strip())
return required

def get_top_level_modules(self):
Expand Down
4 changes: 1 addition & 3 deletions python-magic/service/updater.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@ def __init__(self, *args, **kwargs):
# def is_valid(self, file_path) -> bool:
# return True

def import_update(
self, files_sha256, source, default_classification
) -> None:
def import_update(self, files_sha256, source, default_classification) -> None:
output_dir = os.path.join(self.latest_updates_dir, source)
os.makedirs(os.path.join(self.latest_updates_dir, source), exist_ok=True)
for file, _ in files_sha256:
Expand Down

0 comments on commit e5524a0

Please sign in to comment.