Fix sort different array keys #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanmai
approved these changes
Aug 2, 2023
sanmai
reviewed
Aug 6, 2023
| @@ -18,7 +18,7 @@ | |||
| */ | |||
| class StandardFilters | |||
| { | |||
|
|
|||
There was a problem hiding this comment.
Can you please revert this change/
There was a problem hiding this comment.
I can't. PHPStorm auto fixing it before commit.
There was a problem hiding this comment.
Can you at least add another test please?
sanmai
reviewed
Aug 6, 2023
| ); | ||
| $expected = array( | ||
| array('a' => 50), |
There was a problem hiding this comment.
Please add another test. We need to be sure it is not a BC break (when existing tests work as before).
sanmai
requested changes
Aug 6, 2023
sanmai
reviewed
Aug 9, 2023
|
@sanmai @PNixx What was fixed here? This is a BC. I would also recommend using If you want fix |
return $a[$property] ?? null <=> $b[$property] ?? null; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.