Fix: htmlentities() shouldn't be called with null (#218)

* Fix: htmlentities(): Passing null to parameter 1 ($string) of type string is deprecated
kalimatas · Oct 4, 2024 · 3a472d5 · 3a472d5
1 parent f6befea
commit 3a472d5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/Liquid/StandardFilters.php b/src/Liquid/StandardFilters.php
@@ -201,6 +201,10 @@ public static function escape($input)
 			return $input;
 		}
 
+		if (is_null($input)) {
+			return '';
+		}
+
 		return htmlentities($input, ENT_QUOTES);
 	}
 

diff --git a/tests/Liquid/StandardFiltersTest.php b/tests/Liquid/StandardFiltersTest.php
@@ -231,6 +231,7 @@ public function testEscape()
 		$data = array(
 			"one Word's not" => "one Word&#039;s not",
 			"&><\"'" => "&amp;&gt;&lt;&quot;&#039;",
+			null => '',
 		);
 
 		foreach ($data as $element => $expected) {