LibWeb: Remove did_request_scroll() IPC call

kalenikaliaksandr · Jun 2, 2024 · f24efc2 · f24efc2
1 parent 5453017
commit f24efc2
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 18 deletions.
diff --git a/Userland/Libraries/LibWeb/Page/Page.h b/Userland/Libraries/LibWeb/Page/Page.h
@@ -278,7 +278,6 @@ class PageClient : public JS::Cell {
     virtual void page_did_unhover_link() { }
     virtual void page_did_change_favicon(Gfx::Bitmap const&) { }
     virtual void page_did_layout() { }
-    virtual void page_did_request_scroll(i32, i32) { }
     virtual void page_did_request_scroll_to(CSSPixelPoint) { }
     virtual void page_did_request_alert(String const&) { }
     virtual void page_did_request_confirm(String const&) { }

diff --git a/Userland/Libraries/LibWebView/ViewImplementation.h b/Userland/Libraries/LibWebView/ViewImplementation.h
@@ -151,7 +151,6 @@ class ViewImplementation {
     Function<void()> on_navigate_forward;
     Function<void()> on_refresh;
     Function<void(Gfx::Bitmap const&)> on_favicon_change;
-    Function<void(i32, i32)> on_scroll_by_delta;
     Function<void(Gfx::IntPoint)> on_scroll_to_point;
     Function<void(Gfx::StandardCursor)> on_cursor_change;
     Function<void(Gfx::IntPoint, ByteString const&)> on_enter_tooltip_area;

diff --git a/Userland/Libraries/LibWebView/WebContentClient.cpp b/Userland/Libraries/LibWebView/WebContentClient.cpp
@@ -149,14 +149,6 @@ void WebContentClient::did_change_url(u64 page_id, URL::URL const& url)
     }
 }
 
-void WebContentClient::did_request_scroll(u64 page_id, i32 x_delta, i32 y_delta)
-{
-    if (auto view = view_for_page_id(page_id); view.has_value()) {
-        if (view->on_scroll_by_delta)
-            view->on_scroll_by_delta(x_delta, y_delta);
-    }
-}
-
 void WebContentClient::did_request_scroll_to(u64 page_id, Gfx::IntPoint scroll_position)
 {
     if (auto view = view_for_page_id(page_id); view.has_value()) {

diff --git a/Userland/Libraries/LibWebView/WebContentClient.h b/Userland/Libraries/LibWebView/WebContentClient.h
@@ -46,7 +46,6 @@ class WebContentClient final
     virtual void did_layout(u64 page_id, Gfx::IntSize) override;
     virtual void did_change_title(u64 page_id, ByteString const&) override;
     virtual void did_change_url(u64 page_id, URL::URL const&) override;
-    virtual void did_request_scroll(u64 page_id, i32, i32) override;
     virtual void did_request_scroll_to(u64 page_id, Gfx::IntPoint) override;
     virtual void did_enter_tooltip_area(u64 page_id, Gfx::IntPoint, ByteString const&) override;
     virtual void did_leave_tooltip_area(u64 page_id) override;

diff --git a/Userland/Services/WebContent/PageClient.cpp b/Userland/Services/WebContent/PageClient.cpp
@@ -309,11 +309,6 @@ Gfx::IntRect PageClient::page_did_request_fullscreen_window()
     return client().did_request_fullscreen_window(m_id);
 }
 
-void PageClient::page_did_request_scroll(i32 x_delta, i32 y_delta)
-{
-    client().async_did_request_scroll(m_id, x_delta, y_delta);
-}
-
 void PageClient::page_did_request_scroll_to(Web::CSSPixelPoint scroll_position)
 {
     // NOTE: The viewport scroll position is updated preemptively, so that subsequent

diff --git a/Userland/Services/WebContent/PageClient.h b/Userland/Services/WebContent/PageClient.h
@@ -107,7 +107,6 @@ class PageClient final : public Web::PageClient {
     virtual Gfx::IntRect page_did_request_maximize_window() override;
     virtual Gfx::IntRect page_did_request_minimize_window() override;
     virtual Gfx::IntRect page_did_request_fullscreen_window() override;
-    virtual void page_did_request_scroll(i32, i32) override;
     virtual void page_did_request_scroll_to(Web::CSSPixelPoint) override;
     virtual void page_did_enter_tooltip_area(Web::CSSPixelPoint, ByteString const&) override;
     virtual void page_did_leave_tooltip_area() override;

diff --git a/Userland/Services/WebContent/WebContentClient.ipc b/Userland/Services/WebContent/WebContentClient.ipc
@@ -29,7 +29,6 @@ endpoint WebContentClient
     did_layout(u64 page_id, Gfx::IntSize content_size) =|
     did_change_title(u64 page_id, ByteString title) =|
     did_change_url(u64 page_id, URL::URL url) =|
-    did_request_scroll(u64 page_id, i32 x_delta, i32 y_delta) =|
     did_request_scroll_to(u64 page_id, Gfx::IntPoint scroll_position) =|
     did_enter_tooltip_area(u64 page_id, Gfx::IntPoint content_position, ByteString title) =|
     did_leave_tooltip_area(u64 page_id) =|