kaiax/auction: implement bid bundling #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyeonLewis
requested review from
blukat29,
yoomee1313 and
ian0371
as code owners
ian0371
approved these changes
Apr 1, 2025
yoomee1313
reviewed
Apr 1, 2025
ulbqb
approved these changes
Apr 1, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
After merging this PR, the bid bundle will be mined if extracted.
Bundle logic
We explicitly do not consider the empty bundle (see
#ExtractBundlesAndIncorporate)The auction module requires the additional boolean field in bundle:
TargetRequired. If it's set totrue, the bundle will be executed only when both conditionsI) it's next to target, ii) target has been executed successfullyare met (see#shouldDiscardBundle, IsConflict).After extracting bundles from each module, it cooperates bundles by target tx (see
#CoordinateTargetTxHash). It changes the order of bundles and makes them "linked" by updating the target tx hash to the last tx id of the prior bundle.Now, the bundle is considered to be removed if target has been popped and
TargetRequired == true(see#FindDependentBundleIdx)Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
I have read the CLA Document and I hereby sign the CLAin first time contribute$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...