Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit group coordinator if member pid gone #611

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Exit group coordinator if member pid gone #611

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef8750f
Fixes #607.
fmcgeough Nov 23, 2024
90e9aca
Fix link, dialyzer issues
fmcgeough Nov 25, 2024
18c0dab
catch noproc instead of doing alive check
fmcgeough Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/brod_group_coordinator.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,13 @@
{lo_cmd_stabilize, AttemptCount, Reason}).

-define(INITIAL_MEMBER_ID, <<>>).
-define(CALL_MEMBER(MemberPid, EXPR),
try
EXPR
catch
exit:{noproc, {gen_server, call, [MemberPid | _]}} ->
exit({shutdown, member_down})
end).

-type config() :: brod:group_config().
-type ts() :: erlang:timestamp().
Expand Down Expand Up @@ -499,7 +506,7 @@ stabilize(#state{ rejoin_delay_seconds = RejoinDelaySeconds
log(State0, info, "re-joining group, reason:~p", [Reason]),

%% 1. unsubscribe all currently assigned partitions
ok = MemberModule:assignments_revoked(MemberPid),
?CALL_MEMBER(MemberPid, MemberModule:assignments_revoked(MemberPid)),

%% 2. some brod_group_member implementations may wait for messages
%% to finish processing when assignments_revoked is called.
Expand Down Expand Up @@ -674,8 +681,8 @@ sync_group(#state{ groupId = GroupId
%% get my partition assignments
Assignment = kpro:find(assignment, RspBody),
TopicAssignments = get_topic_assignments(State, Assignment),
ok = MemberModule:assignments_received(MemberPid, MemberId,
GenerationId, TopicAssignments),
?CALL_MEMBER(MemberPid,
MemberModule:assignments_received(MemberPid, MemberId, GenerationId, TopicAssignments)),
NewState = State#state{is_in_group = true},
log(NewState, info, "assignments received:~s",
[format_assignments(TopicAssignments)]),
Expand Down Expand Up @@ -834,7 +841,7 @@ assign_partitions(State) when ?IS_LEADER(State) ->
Assignments =
case Strategy =:= callback_implemented of
true ->
MemberModule:assign_partitions(MemberPid, Members, AllPartitions);
?CALL_MEMBER(MemberPid, MemberModule:assign_partitions(MemberPid, Members, AllPartitions));
false ->
do_assign_partitions(Strategy, Members, AllPartitions)
end,
Expand Down