Remove snappyer from default dependency #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, why is there a rebar.lock file in this repo? |
|
Hi @belltoy |
|
Rebased onto the latest master branch. Changes:
|
|
Thank you @belltoy will release a major version soon. |
|
Thanks, Stone. |
|
+1 for this. I'm trying to compile on OTP 27 and |
yordis
approved these changes
Jun 24, 2024
zmstone
approved these changes
Jun 26, 2024
|
released 4.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The snappy support is optional and configurable after kafka_protocol 4.0 in #459, so it should not be a default dependency. Besides, making it default will prevent users from excluding it.
This is a breaking change. Users using producers and/or consumers with compression enabled must explicitly add a compression application/module.