Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicate pre-insert checks; #2140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid duplicate pre-insert checks; #2140

wants to merge 1 commit into from

Conversation

edmundnoble
Copy link
Contributor

Store a set of currently-being-inserted txs across in the mempool. This way we can avoid doing duplicate pre-insert checks, which is good, because those could take a while depending on what PactService is busy with.

Change-Id: Id0000000759106e235d28e052289a229f49212ef

@edmundnoble
Avoid duplicate pre-insert checks;
9c11193 
Store a set of currently-being-inserted txs across in the mempool.
This way we can avoid doing duplicate pre-insert checks, which is
good, because those could take a while depending on what PactService
is busy with.

Change-Id: Id0000000759106e235d28e052289a229f49212ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwiegley jwiegley jwiegley left review comments

@chessai chessai chessai approved these changes

@larskuhtz larskuhtz Awaiting requested review from larskuhtz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edmundnoble @jwiegley @chessai