Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Add argument for namespace #1062

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

jochenseeber
Copy link

@jochenseeber jochenseeber commented Apr 29, 2024

Allows accessing Kadalu installations installed in other namespaces than the default "kadalu"

What this PR does / why we need it:

This is useful for multi-tenant setups where multiple Kadalu instances run in different namespaces.

Which issue(s) this PR fixes:

No issue

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

Allows accessing Kadalu installations installed in other namespaces
than the default "kadalu". This is useful for multi-tenant setups.
@leelavg
Copy link
Collaborator

leelavg commented Apr 29, 2024

where multiple Kadalu instances

  • Could you pls specify the intention a bit more clearly? You can deploy Kadalu CRs in multiple namespaces and operator running in kadalu ns can reconcile based on that
  • The code changes are for running Kadalu Operator & CSI in a different ns and multiple collides with that intention as CSI pods should be running in single namespace only.

btw, pls do sign your commit (git commit --amend -s --no-edit), thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants