This repository has been archived by the owner on Feb 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 728
[Needs improvement] Playlist dialog: Add checkmark to indicate if song is in playlist #432
Open
Sogolumbo
wants to merge
37
commits into
kabouzeid:master
Choose a base branch
from
Sogolumbo:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Feb 12, 2018
-
Playlist dialog: Add checkmark to indicate if song is in playlist
The "Add to playlist" dialog will show checkmark behind a playlist if the song is already part of that playlist. This feature will only be shown if the playlist dialog is opened and only one song is selected.
Configuration menu - View commit details
-
Copy full SHA for 6bac337 - Browse repository at this point
Copy the full SHA 6bac337View commit details
Commits on Feb 20, 2018
-
By adding a breakpoint the time needed for checking the playlists for the song can be accessed.
Configuration menu - View commit details
-
Copy full SHA for f9fba4e - Browse repository at this point
Copy the full SHA f9fba4eView commit details
Commits on Sep 5, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 575bb69 - Browse repository at this point
Copy the full SHA 575bb69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 132d597 - Browse repository at this point
Copy the full SHA 132d597View commit details
Commits on Jan 12, 2019
-
Merge pull request #2 from kabouzeid/master
Merge Updates from kabouzeid/master.
Configuration menu - View commit details
-
Copy full SHA for dfba214 - Browse repository at this point
Copy the full SHA dfba214View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67262fa - Browse repository at this point
Copy the full SHA 67262faView commit details
Commits on Feb 8, 2019
-
Enable playlist-checking for adding multiple songs to a playlist
At the end of the playlist name a checkmark is displayed if all songs are in the playlist. If only some of the songs are in the playlist, the checkmark is in brackets.
Configuration menu - View commit details
-
Copy full SHA for d91f11a - Browse repository at this point
Copy the full SHA d91f11aView commit details -
No more duplicate songs added to playlists; Code cleanup
When adding songs to a playlist duplicates will be filtered out.
Configuration menu - View commit details
-
Copy full SHA for e81f655 - Browse repository at this point
Copy the full SHA e81f655View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b6f91e - Browse repository at this point
Copy the full SHA 7b6f91eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a48d35 - Browse repository at this point
Copy the full SHA 6a48d35View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cbb569 - Browse repository at this point
Copy the full SHA 8cbb569View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21c0971 - Browse repository at this point
Copy the full SHA 21c0971View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa770ff - Browse repository at this point
Copy the full SHA fa770ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for eda7037 - Browse repository at this point
Copy the full SHA eda7037View commit details
Commits on Jun 3, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 8254527 - Browse repository at this point
Copy the full SHA 8254527View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c1b25c - Browse repository at this point
Copy the full SHA 2c1b25cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 780292f - Browse repository at this point
Copy the full SHA 780292fView commit details
Commits on Jul 21, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 7896c8e - Browse repository at this point
Copy the full SHA 7896c8eView commit details -
Change and add functions in PlaylistUtil
Changed and added functions in PlaylistUtil to improve the efficiency of the AddToPlaylistDialog. It will only be checked once which song is in which playlist. This information is also used to make sure no songs will be added twice to the same playlist (instead of checking again).
Configuration menu - View commit details
-
Copy full SHA for 4512b43 - Browse repository at this point
Copy the full SHA 4512b43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7380f4c - Browse repository at this point
Copy the full SHA 7380f4cView commit details
Commits on Jul 22, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 04fc392 - Browse repository at this point
Copy the full SHA 04fc392View commit details -
Configuration menu - View commit details
-
Copy full SHA for 083d794 - Browse repository at this point
Copy the full SHA 083d794View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69505e5 - Browse repository at this point
Copy the full SHA 69505e5View commit details
Commits on May 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c477a6d - Browse repository at this point
Copy the full SHA c477a6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c4e177 - Browse repository at this point
Copy the full SHA 0c4e177View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14b35fc - Browse repository at this point
Copy the full SHA 14b35fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for fcdba15 - Browse repository at this point
Copy the full SHA fcdba15View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec16d51 - Browse repository at this point
Copy the full SHA ec16d51View commit details
Commits on Aug 22, 2020
-
doPlaylistContainsAllSongs returned true if the playlist was empty. That's a wrong result, hence fixed with this commit.
Configuration menu - View commit details
-
Copy full SHA for 28cbfa8 - Browse repository at this point
Copy the full SHA 28cbfa8View commit details -
First Prototype: Working check box menu. Only two state-check-boxes (All or nothing)
Configuration menu - View commit details
-
Copy full SHA for acbf3c5 - Browse repository at this point
Copy the full SHA acbf3c5View commit details -
Removed "Add Playlist" from the checkbox area and transformed it into a button.
Configuration menu - View commit details
-
Copy full SHA for 84b859f - Browse repository at this point
Copy the full SHA 84b859fView commit details
Commits on Aug 29, 2020
-
Remove cancel button from 'add to playlist' dialog
The cancel button is removed as it takes up a lot of space and is not strictly necessary. (The same action can be performed by tapping next to the dialog.)
Configuration menu - View commit details
-
Copy full SHA for f80dbd3 - Browse repository at this point
Copy the full SHA f80dbd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66c169e - Browse repository at this point
Copy the full SHA 66c169eView commit details
Commits on Sep 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 3984ea2 - Browse repository at this point
Copy the full SHA 3984ea2View commit details
Commits on Sep 14, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 92587c5 - Browse repository at this point
Copy the full SHA 92587c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for e481f13 - Browse repository at this point
Copy the full SHA e481f13View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad0fb5c - Browse repository at this point
Copy the full SHA ad0fb5cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.