Skip to content

Commit

Permalink
reconciler: update logging call
Browse files Browse the repository at this point in the history
All (non error) logs have the same verbosity; it would be interesting
to see the reconciled IPs by default, as such I'm bumping this
particular logging call to `verbose`.
That enables users to `kubectl logs <reconciler-pod-name` and see which
IP addresses got reconciled.

The below calls would be bumped to `verbose`.
```
2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.100]
2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.111]
2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.113]
2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.118]
2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.13]
2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.170]
2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.18]
2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.3]
2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.35]
2021-10-20T15:50:00Z [debug] removed stale overlappingIP allocation [10.10.0.4]
2021-10-20T15:50:01Z [debug] removed stale overlappingIP allocation [10.10.0.83]
```

Signed-off-by: Miguel Duarte Barroso <[email protected]>
  • Loading branch information
maiqueb committed Oct 20, 2021
1 parent 7448316 commit b9a9102
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/reconciler/iploop.go
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ func (rl ReconcileLooper) ReconcileOverlappingIPAddresses() error {
failedReconciledClusterWideIPs = append(failedReconciledClusterWideIPs, overlappingIPStruct.GetName())
continue
}
logging.Debugf("removed stale overlappingIP allocation [%s]", overlappingIPStruct.GetName())
logging.Verbosef("removed stale overlappingIP allocation [%s]", overlappingIPStruct.GetName())
}

if len(failedReconciledClusterWideIPs) != 0 {
Expand Down

0 comments on commit b9a9102

Please sign in to comment.