Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[software-bridges 4/x] Controller part #694

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[software-bridges 4/x] Controller part #694

wants to merge 4 commits into from

Conversation

ykulazhenkov
Copy link
Collaborator

@ykulazhenkov ykulazhenkov commented Apr 30, 2024 •
edited

This PR contains controller's part of the software bridge management feature.

Context is Software bridge management feature

@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Apr 30, 2024 •
edited

Pull Request Test Coverage Report for Build 9203831155

Details

  • 72 of 79 (91.14%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 39.957%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/sriov-network-config-daemon/start.go 1 2 50.0%
pkg/systemd/systemd.go 0 1 0.0%
controllers/sriovnetworknodepolicy_controller.go 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
controllers/drain_controller.go 1 68.06%
Totals Coverage Status
Change from base Build 9203023396: 0.4%
Covered Lines: 5198
Relevant Lines: 13009
💛 - Coveralls

@ykulazhenkov
Add manageSoftwareBridges feature gate
72569cb 
The feature gate controls state of the
manage software bridge feature.
This feature is disabled by default.

Signed-off-by: Yury Kulazhenkov <[email protected]>
@ykulazhenkov
Add logic to apply OVS bridge policy to state
47aaa5e 
Signed-off-by: Yury Kulazhenkov <[email protected]>
@ykulazhenkov
Add validation for bridge config to webhook
012faec 
Signed-off-by: Yury Kulazhenkov <[email protected]>
@ykulazhenkov
Add logic to SriovNetworkNodePolicy controller to populate bridge config
c6392ae 
Signed-off-by: Yury Kulazhenkov <[email protected]>
@ykulazhenkov ykulazhenkov force-pushed the pr-autobridge-controller-part branch from 4b1cfdb to c6392ae Compare May 23, 2024 07:17
@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ykulazhenkov @coveralls