Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump the gomod-dependencies and go version in go.mod #620

Closed

Conversation

adilGhaffarDev
Copy link
Contributor

This PR is doing following bumps:

This PR is also bumping go version in go.mod file from 1.22.4->1.23.4

This PR also fixes:
Vulnerability: CVE-2024-45338
Severity: HIGH
Information: https://avd.aquasec.com/nvd/cve-2024-45338
Module: golang.org/x/net

@coveralls
Copy link
Collaborator

coveralls commented Jan 10, 2025

Pull Request Test Coverage Report for Build 12763118130

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.603%

Totals Coverage Status
Change from base Build 12352758386: 0.0%
Covered Lines: 2115
Relevant Lines: 2835

💛 - Coveralls

@adilGhaffarDev
Copy link
Contributor Author

this PR is taking over this auto-bump PR: #617

@@ -1,23 +1,23 @@
module github.com/k8snetworkplumbingwg/sriov-network-device-plugin

go 1.22.4
go 1.23.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for golang version bump need to update workflows and Dockerfiles under images as well. currently they point to 1.22

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@adilGhaffarDev
Copy link
Contributor Author

@adrianchiris please check

@SchSeba
Copy link
Collaborator

SchSeba commented Jan 21, 2025

Hi @adilGhaffarDev,

the linter is failing can you take a look on my PR #623 and implement it here so we can merge it?

@adilGhaffarDev
Copy link
Contributor Author

the linter is failing can you take a look on my PR #623 and implement it here so we can merge it?

I will close mine, let's merge yours since it already has all the fixes and bumps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants