Revert mtu #316
Merged
Revert mtu #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12732442456Details
💛 - Coveralls |
cgoncalves
reviewed
Jan 7, 2025
| @@ -225,6 +225,18 @@ func (s *sriovManager) ReleaseVF(conf *sriovtypes.NetConf, podifName string, net | |||
| } | |||
| } | |||
|
|
|||
| // reset MTU for VF device until if the MTU was captured in the cache | |||
| if conf.OrigVfState.MTU != 0 { | |||
| logging.Debug("Reset VF device MTU", | |||
There was a problem hiding this comment.
Print out the desired MTU value (conf.OrigVfState.MTU).
|
@SchSeba why do we need to reset VF MTU if we never set it in the CNI ? currently we save the PF or VF mtu in conf to report it in cni results but never set it |
we introduce this feature in the cni to handle cases where a pod that used the vf has net_admin and change the MTU on the VF. when that po is removed the VF will go back to the host and be available for a new pod to run but when that VF gets allocated to the pod it will remain with an unexpected MTU. Signed-off-by: Sebastian Sch <[email protected]>
|
Hi @adrianchiris, let me know if that works for you |
adrianchiris
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we introduce this feature in the cni to handle cases where a pod that used the vf has net_admin and change the MTU
on the VF.
when that pod is removed the VF will go back to the host and be available
for a new pod to run but when that VF gets allocated to the pod it will
remain with an unexpected MTU.