create multus kubeconfig for in case of non auto flag. #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is based on #1302 , after rebase on master and some streamlining of the test to reduce code changes in thin_entrypoint. |
|
@dougbtv PTAL |
dougbtv
approved these changes
Aug 1, 2024
| "testing" | ||
|
|
||
| . "github.com/onsi/ginkgo/v2" //nolint:golint | ||
| . "github.com/onsi/gomega" //nolint:golint | ||
| ) | ||
|
|
||
| // chrootTestHelper performs chroot syscall, returns func to get back to original root or error if occurred | ||
| func chrootTestHelper(path string) (func() error, error) { |
| @@ -585,6 +585,11 @@ func main() { | |||
| var masterConfigFilePath string | |||
| // copy user specified multus conf to CNI conf directory | |||
| if opt.MultusConfFile != "auto" { | |||
| caHash, saTokenHash, err = opt.createKubeConfig(nil, nil) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small rework of PR#1302 to reduce code changes for test.
Fixes #1295