Update DRA integration info and fix e2e test #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vasilis Remmas <[email protected]>
adrianchiris
approved these changes
Jul 25, 2024
dougbtv
approved these changes
Jul 25, 2024
|
Let's try to follow up next maintainer's meeting and see what needs to change for 1.31 compatibility, too, thanks for this fix!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Kubernetes 1.31, the DRA API will change (1,2). The dra example implementation has already been updated to some extent to reflect those changes. Current e2e tests fail because of that.
With this PR, we add additional info in the docs to reflect the versions of Kubernetes that multus supports DRA and also we fix the e2e test by pinning it to the original DRA example implementation.
Next step is to adjust the multus DRA integration to the new DRA API.
Note: The currently opened PRs will need to be rebased on top of master once this PR is merged to ensure that e2e test is passing.