remove vendoring, use Go modules #1287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the proposed change, I'm going to bring it to the NPWG main meeting and discuss, feel free to join, I added to the agenda for next week @ https://docs.google.com/document/d/1oE93V3SgOGWJ4O1zeD1UmpeToa0ZiiO6LqRAmZBPFWM/edit |
Removes the vendor/ directory and all vestiges of life before Go modules. Issue k8snetworkplumbingwg/sriov-network-device-plugin#544 Signed-off-by: Jay Pipes <[email protected]>
|
@dougbtv if you could approve the running of the workflows when you get a chance, that would be groovy, thanks! :) |
|
+1 on removing vendoring. we already did that did that for a bunch of projects in ngwg (sriov dp, cni, operator) |
|
This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the vendor/ directory and all vestiges of life before Go modules.
Issue k8snetworkplumbingwg/sriov-network-device-plugin#544