Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thick plugin should not wait for API readiness on CNI DEL #1279

Merged

Conversation

dougbtv
Copy link
Member

@dougbtv dougbtv commented May 14, 2024

This modifies the behavior on CNI DEL for the thick plugin to just check once for API readiness, as opposed to waiting.

@coveralls
Copy link

coveralls commented May 14, 2024

Coverage Status

coverage: 62.943%. remained the same
when pulling 181f56f on dougbtv:skip-api-ready-on-cni-del
into 5a2597b on k8snetworkplumbingwg:master.

This modifies the behavior on CNI DEL for the thick plugin to just check once for API readiness, as opposed to waiting.
@dougbtv dougbtv force-pushed the skip-api-ready-on-cni-del branch from 0c1ddd9 to 181f56f Compare May 14, 2024 15:23
Copy link
Member

@s1061123 s1061123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@s1061123 s1061123 merged commit 75c0245 into k8snetworkplumbingwg:master May 15, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants