Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CNI cache update function to prevent nil access #1274

Merged
merged 1 commit into from
May 9, 2024

Conversation

s1061123
Copy link
Member

@s1061123 s1061123 commented May 9, 2024

deleteDefaultGWResult() may create 'routes:null' in CNI cache file and it causes nil pointer access at addDefaultGWCacheBytes(). This code change prevents deleteDefaultGWResult() to generate 'routes:null' in cache file.

deleteDefaultGWResult() may create 'routes:null' in CNI cache file
and it causes nil pointer access at addDefaultGWCacheBytes().
This code change prevents deleteDefaultGWResult() to generate
'routes:null' in cache file.
@s1061123 s1061123 requested a review from dougbtv May 9, 2024 04:36
@coveralls
Copy link

Coverage Status

coverage: 62.92% (+0.03%) from 62.889%
when pulling 5fe1249 on s1061123:fix/gateway-nil
into 4457289 on k8snetworkplumbingwg:master.

@dougbtv
Copy link
Member

dougbtv commented May 9, 2024

results in the error:

wrong routes format

@dougbtv dougbtv merged commit 7821764 into k8snetworkplumbingwg:master May 9, 2024
24 checks passed
@s1061123 s1061123 deleted the fix/gateway-nil branch May 9, 2024 13:36
s1061123 pushed a commit that referenced this pull request May 9, 2024
Fix CNI cache update function to prevent nil access
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants