Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filepath sanity check #1229

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Add filepath sanity check #1229

merged 1 commit into from
Feb 14, 2024

Conversation

s1061123
Copy link
Member

@s1061123 s1061123 commented Feb 14, 2024 •
edited by dougbtv
Loading

Uses filepath.Abs() to check that paths passed in are truly absolute paths, and not garbage data (for example).

@coveralls
Copy link

coveralls commented Feb 14, 2024 •
edited
Loading

Coverage Status

coverage: 63.603% (+0.5%) from 63.109%
when pulling 7489302 on s1061123:fix/filepath
into c550826 on k8snetworkplumbingwg:master.

dougbtv
dougbtv approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@dougbtv dougbtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dougbtv dougbtv merged commit b271fbf into k8snetworkplumbingwg:master Feb 14, 2024
24 checks passed
@s1061123 s1061123 deleted the fix/filepath branch May 9, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbtv dougbtv dougbtv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s1061123 @coveralls @dougbtv