Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to use lumberjack only for logging files #1194

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

s1061123
Copy link
Member

@s1061123 s1061123 commented Dec 7, 2023

No description provided.

@coveralls
Copy link

Coverage Status

coverage: 63.211% (+0.05%) from 63.162%
when pulling 540a887 on s1061123:fix-logging
into e4404b2 on k8snetworkplumbingwg:master.

Copy link
Member

@dougbtv dougbtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dougbtv dougbtv merged commit c76db9c into k8snetworkplumbingwg:master Dec 7, 2023
24 checks passed
@s1061123 s1061123 deleted the fix-logging branch December 7, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants