Add per-node-certification support #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1061123
force-pushed
the
per-node-cert
branch
2 times, most recently
from
d0f2740
to
049ec70
Compare
This change introduces per-node certification for multus pods. Once multus pod is launched, then specified bootstrap kubeconfig is used for initial access, then multus sends CSR request to kube API to get original certs for kube API access. Once it is accepted then the multus pod uses generated certs for kube access.
s1061123
force-pushed
the
per-node-cert
branch
from
049ec70
to
e5d19ff
Compare
dougbtv
approved these changes
Sep 18, 2023
| @@ -393,87 +387,6 @@ func TryLoadPodDelegates(pod *v1.Pod, conf *types.NetConf, clientInfo *ClientInf | |||
| return 0, clientInfo, err | |||
| } | |||
|
|
|||
| // InClusterK8sClient returns the `k8s.ClientInfo` struct to use to connect to | |||
There was a problem hiding this comment.
This is all removed because of Dan's recent performance work, right?
| } | ||
|
|
||
| // GetK8sClient gets client info from kubeconfig | ||
| func GetK8sClient(kubeconfig string, kubeClient *ClientInfo) (*ClientInfo, error) { |
There was a problem hiding this comment.
Ok, I get it, the GetK8sClient moves here, makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces per-node certification for multus pods. Once multus pod is launched, then specified bootstrap kubeconfig is used for initial access, then multus sends CSR request to kube API to get original certs for kube API access. Once it is accepted then the multus pod uses generated certs for kube access.
This PR only targets the code and doc/installer manifests will be addressed in another PR.