Verify sha256sum for kubelet, vagrant zip and go binary#13889
Verify sha256sum for kubelet, vagrant zip and go binary#13889manuelbuil merged 1 commit intok3s-io:mainfrom
Conversation
e177b09 to
fff439a
Compare
|
I think we're meant to pin the sha directly in-file, pulling it along with the artifacts wouldnt stop a trivy-esque attack cc @macedogm That said it kubectl is compromised it's basically game over isn't it |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13889 +/- ##
==========================================
- Coverage 22.38% 22.32% -0.06%
==========================================
Files 193 193
Lines 15631 15631
==========================================
- Hits 3499 3490 -9
- Misses 11650 11661 +11
+ Partials 482 480 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Do you have an example of how it should look like? I have used this approach in many other PRs |
|
Something along these lines: |
|
@cwayne18 can sha also be compromised for these upstream binaries? is that the reason behind pinning in-file? |
Signed-off-by: Manuel Buil <mbuil@suse.com>
fff439a to
921ed20
Compare
Proposed Changes
Verify the sha256sum for both Kubelet, vagrant zip and go binary.
It also updates the GO version
Types of Changes
Security imrpovement
Verification
Testing
Linked Issues
#13886
User-Facing Change
Further Comments