Skip to content

Make tests/integration/Dockerfile.test more secure#13883

Merged
manuelbuil merged 1 commit intok3s-io:mainfrom
manuelbuil:fixIntegrationDockerfileTest
Apr 1, 2026
Merged

Make tests/integration/Dockerfile.test more secure#13883
manuelbuil merged 1 commit intok3s-io:mainfrom
manuelbuil:fixIntegrationDockerfileTest

Conversation

@manuelbuil
Copy link
Copy Markdown
Contributor

@manuelbuil manuelbuil commented Mar 31, 2026

Proposed Changes

Make the Dockerfile.test more secure by:

  • Remove the "dep" installation because it is not needed and "curl" either
  • Adding "--no-install-recommends" to reduce unnecessary packages.
  • Removed apt metadata after install with rm -rf /var/lib/apt/lists/*.
  • Pin the ginkgo and gomega version when installing it via "go install"

Types of Changes

Security improvements

Verification

Testing

Linked Issues

#13886

User-Facing Change


Further Comments

@manuelbuil manuelbuil requested a review from a team as a code owner March 31, 2026 13:59
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 22.32%. Comparing base (f1deb4e) to head (68de0de).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13883      +/-   ##
==========================================
- Coverage   22.38%   22.32%   -0.06%     
==========================================
  Files         193      193              
  Lines       15631    15631              
==========================================
- Hits         3499     3490       -9     
- Misses      11650    11661      +11     
+ Partials      482      480       -2     
Flag Coverage Δ
unittests 22.32% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Manuel Buil <mbuil@suse.com>
@manuelbuil manuelbuil force-pushed the fixIntegrationDockerfileTest branch from 636f3ad to 68de0de Compare March 31, 2026 14:11
@manuelbuil manuelbuil merged commit 77edf27 into k3s-io:main Apr 1, 2026
19 checks passed
@manuelbuil manuelbuil deleted the fixIntegrationDockerfileTest branch April 1, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants