-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Windows compilation test to GHA and enable tests #11713
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73033d6
to
9c6bbc1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11713 +/- ##
==========================================
- Coverage 49.61% 46.77% -2.84%
==========================================
Files 186 206 +20
Lines 19461 19483 +22
==========================================
- Hits 9655 9113 -542
- Misses 8410 9043 +633
+ Partials 1396 1327 -69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1d6fd10
to
d74361c
Compare
dereknola
reviewed
Feb 6, 2025
dereknola
previously approved these changes
Feb 6, 2025
29c1265
to
45de69e
Compare
…verage Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
Netpol startup is skipped with a warning on linux if ipset support is missing, we should do the same on windows Signed-off-by: Brad Davidson <[email protected]>
matttrach
previously approved these changes
Feb 7, 2025
Signed-off-by: Brad Davidson <[email protected]>
dereknola
approved these changes
Feb 7, 2025
matttrach
approved these changes
Feb 7, 2025
This was referenced Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Part of ongoing efforts to improve Windows coverage by mainstreaming how we build and test for Windows.
Types of Changes
windows
Verification
check CI results
Testing
yes
Linked Issues
User-Facing Change
Further Comments