Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Windows compilation test to GHA and enable tests #11713

Merged
merged 16 commits into from
Feb 7, 2025

Conversation

brandond
Copy link
Member

@brandond brandond commented Feb 5, 2025

Proposed Changes

  • Move Windows compilation test to GH Actions
  • Enable integration/coverage/smoke tests
  • Fix multiple issues with windows configuration.

Part of ongoing efforts to improve Windows coverage by mainstreaming how we build and test for Windows.

Types of Changes

windows

Verification

check CI results

Testing

yes

Linked Issues

User-Facing Change


Further Comments

@brandond brandond requested a review from a team as a code owner February 5, 2025 00:28
@brandond brandond force-pushed the gh-windows branch 2 times, most recently from 73033d6 to 9c6bbc1 Compare February 5, 2025 01:21
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 23.63636% with 42 lines in your changes missing coverage. Please review.

Project coverage is 46.77%. Comparing base (85b3775) to head (2d34a73).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
pkg/util/permissions/permissions_windows.go 0.00% 30 Missing ⚠️
pkg/cli/agent/agent.go 25.00% 2 Missing and 1 partial ⚠️
pkg/cli/server/server.go 25.00% 2 Missing and 1 partial ⚠️
pkg/util/permissions/permissions_others.go 40.00% 2 Missing and 1 partial ⚠️
pkg/agent/netpol/netpol_windows.go 0.00% 2 Missing ⚠️
pkg/agent/containerd/config.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11713      +/-   ##
==========================================
- Coverage   49.61%   46.77%   -2.84%     
==========================================
  Files         186      206      +20     
  Lines       19461    19483      +22     
==========================================
- Hits         9655     9113     -542     
- Misses       8410     9043     +633     
+ Partials     1396     1327      -69     
Flag Coverage Δ
e2etests 40.36% <33.33%> (-3.71%) ⬇️
inttests 34.90% <27.77%> (-0.08%) ⬇️
unittests 16.29% <12.72%> (-0.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond force-pushed the gh-windows branch 8 times, most recently from 1d6fd10 to d74361c Compare February 6, 2025 09:57
dereknola
dereknola previously approved these changes Feb 6, 2025
Netpol startup is skipped with a warning on linux if ipset support is missing, we should do the same on windows

Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond changed the title Move Windows compilation test to GH Actions and enable integration/coverage Move Windows compilation test to GHA and enable tests Feb 7, 2025
matttrach
matttrach previously approved these changes Feb 7, 2025
Signed-off-by: Brad Davidson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants