Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated ruby function in e2e tests #10084

Merged
merged 1 commit into from May 13, 2024

Conversation

manuelbuil
Copy link
Contributor

Proposed Changes

exists was deprecated since ruby 2.1 and removed in ruby 3.2:
https://www.ruby-lang.org/en/news/2022/12/25/ruby-3-2-0-released/

Types of Changes

Bugfix

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

Thanks @mgfritch

@manuelbuil manuelbuil requested a review from a team as a code owner May 10, 2024 11:12
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.79%. Comparing base (1454953) to head (165353f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10084      +/-   ##
==========================================
- Coverage   47.77%   41.79%   -5.98%     
==========================================
  Files         173      173              
  Lines       14645    14645              
==========================================
- Hits         6996     6121     -875     
- Misses       6317     7362    +1045     
+ Partials     1332     1162     -170     
Flag Coverage Δ
e2etests 36.38% <ø> (-10.06%) ⬇️
inttests 37.08% <ø> (+17.27%) ⬆️
unittests 11.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants