Skip to content

Change worker labels to be a map #5822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change worker labels to be a map #5822

wants to merge 1 commit into from
+15 −7

Conversation

twz123
Copy link
Member

@twz123 twz123 commented May 7, 2025

Description

This is the way they're implemented in the kubelet, as well. Re-use Kubernetes' Cobra flag wrapper for (de-)serialization.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123
Change worker labels to be a map
fff5d7e 
This is the way they're implemented in the kubelet, as well. Re-use
Kubernetes' Cobra flag wrapper for (de-)serialization.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 force-pushed the worker-labels-map branch from 19ca0aa to fff5d7e Compare May 7, 2025 09:48
@twz123 twz123 marked this pull request as ready for review May 8, 2025 13:38
@twz123 twz123 requested review from a team as code owners May 8, 2025 13:38
@twz123 twz123 requested review from ncopa and kke May 8, 2025 13:38
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2025

The PR is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Jun 7, 2025
@twz123 twz123 removed the Stale label Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

@kke kke Awaiting requested review from kke kke is a code owner automatically assigned from k0sproject/k0s-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/cli chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@twz123