Fix google-generativeai import related issues #700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update pyproject settings and package imports to prevent ModuleNotFound errors
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to c719247 in 1 minute and 52 seconds
More details
- Looked at
53lines of code in3files - Skipped
1files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. pyproject.toml:41
- Draft comment:
The addition ofgoogle-generativeaito thetest-docsgroup inpyproject.tomlis appropriate to ensure the package is available in testing environments, aligning with the PR's intent to fix import issues. - Reason this comment was not posted:
Confidence changes required:0%
The PR description mentions updating pyproject settings and package imports to prevent ModuleNotFound errors. The changes in thepyproject.tomlfile include adding thegoogle-generativeaipackage to thetest-docsgroup, which is a necessary update to ensure that the package is available for testing environments where it might be needed. This change aligns with the PR's intent to fix import issues and seems correctly implemented.
Workflow ID: wflow_TAxW5lj3PzdO2Rir
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -387,6 +387,8 @@ def handle_response_model( | |||
| ) | {"response_mime_type": "application/json"} | |||
|
|
|||
| # minimize gemini safety related errors - model is highly prone to false alarms | |||
| from google.generativeai.types import HarmCategory, HarmBlockThreshold | |||
There was a problem hiding this comment.
Consider moving the import statement for HarmCategory and HarmBlockThreshold to the top of the file to avoid performance penalties from importing inside a function:
Suggested change
| from google.generativeai.types import HarmCategory, HarmBlockThreshold | |
| from google.generativeai.types import HarmCategory, HarmBlockThreshold |
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update pyproject settings and package imports to prevent ModuleNotFound errors introduced in #684
Summary:
This PR fixes import issues related to 'google-generativeai' by updating import conditions and dependencies.
Key points:
instructor/__init__.pyto check for 'google' module before importing 'from_gemini'.HarmCategoryandHarmBlockThresholdfrom 'google.generativeai.types' ininstructor/process_response.pyfor handling safety settings.pyproject.toml.Generated with ❤️ by ellipsis.dev