This repository was archived by the owner on Aug 23, 2025. It is now read-only.
Allow leading doc-strings when (re-)defining faces via :custom-face#1065
Open
antler5 wants to merge 2 commits intojwiegley:masterfrom
Open
Allow leading doc-strings when (re-)defining faces via :custom-face#1065antler5 wants to merge 2 commits intojwiegley:masterfrom
antler5 wants to merge 2 commits intojwiegley:masterfrom
Conversation
Requires such doc-strings to be typed as literal strings at compile-time -- no `(concat [...])' forms.
* use-package-core.el(use-package-normalize/:custom-face):
Type-check `spec-type` at compile time.
Fun fact: `(symbolp '()) ; => t`!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires such doc-strings to be typed as literal strings at compile-time -- no
(concat [...])forms.Just a piece of my personal config for postarity.
Includes updates to the README, manual, and tests, though I left it unspoken that the string must be a literal.
I like #1048 too, I think that checks out.