Put functions in scope in the :config block #1059
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, `use-package p` puts in scope all the symbols declared by package p in scope of its :config block. The tradeoff is that init is slightly slower *if interpreted*. Compiling init.el gives the same runtime behaviour as previously. Fixes jwiegley#1032
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1032, which also provides background.
With this change,
use-package pputs in scope all the symbols declared by package p in scope of its :config block. The tradeoff is that init is slightly slower if interpreted. Compilinginit.elgives the same runtime behavior as previously.Perhaps there is a way to change
use-package--eval-when-compileto obtain both fewer warnings at compile time and best runtime complexity, but this is beyond my elisp understanding.