fix: use visual mode for operator-pending mode f/t (#292 rebase with tests) #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1eb049 (fix for justinmk#177) broke operator-pending mode f when the target is on eol/eof (justinmk#291). Revert that commit in order to fix justinmk#291, and introduce an alternative fix for justinmk#177: exit visual mode if target is not found. Fixes justinmk#291, justinmk#177
Owner
|
Thanks for taking this up!
if the |
Contributor
Author
|
Yeah, I'm currently in the dark how it works but the tests can drive it forward in either case :) |
Owner
|
True, let's start with this and see how it goes. |
Contributor
Author
|
Ah, mind if I open an issue so we remember to look into it later? #321 |
Contributor
Author
|
Btw @tomtomjhj thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is #292 raised from the dead to address questions in #291 that were never answered
Fix #291
Fix #228
Close #292
All the tests pass, but let me know if more edge cases are known
A limitation of the visual-mode approach is: it messes with the
<>marks, try for example:vip, return to normal modedfxgvPerhaps should either save and restore the marks, or consider some other approach given in #228 (comment) (@ggandor do you have an opinion on this?)