Keep OpenEXR on version that's compatible with KImageFormats #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenEXR 3.3 introduced a change that broke compatibility with KImageFormats. It was fixed in KImageFormats 6.8, but even if you updated to that, you still need to keep KImageFormats 5.x compatibility for the Qt5 builds. This PR uses the overlay port capability in vcpkg to override the files for the OpenEXR port, keeping it on 3.2.4 regardless of the vcpkg commit ID in use. The port files I added in the
util
folder were taken from here, which is the last commit to update the port before it went to 3.3. The other way to request a specific version of a port from vcpkg is a bit more involved, so I thought you would appreciate this simpler workaround for now.I already ran this through my Actions workflow and produced qView builds for Windows/macOS to test it, and all 5 of them (macOS Universal/x64, Windows x64/ARM64/x86) are able to load my test suite of images without regression. The only update that's needed on the qView side is to change the filename in the Windows plugin copying from
lcms2.dll
tolcms2-2.dll
(I will PR that), which changed after an update because I bumped thevcpkgCommitId
here too. vcpkg finally updated the AOM port today, by the way, so the x86 Windows build is back to completing in about ~15 minutes. 🎉