Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time thankfully not a regression; I don't believe this has ever worked. The "install name" for KArchive is different depending on whether we built with Qt5 or Qt6, so the
install_name_tool
command was only able to find/change the specified name in the Qt6 builds. This resulted in the legacy macOS qView being unable to load KRA/ORA files. I ran this fix through my Actions pipeline and can verify the names are correct in both cases now, e.g.:(Universal binary hence the two names in the Qt6 build).
By the way, this is a little test suite of images I gathered to test a lot (but not all) of the KImageFormats decoders. There's only one file in there you won't be able to open (.pxr) since the decoder is only in KDE Frameworks 6 (I updated my fork to that a while back; can PR eventually but probably not worth focusing on right now).