Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS/Qt5: Fix KRA/ORA #8

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

jdpurcell
Copy link
Contributor

@jdpurcell jdpurcell commented Oct 16, 2024

This time thankfully not a regression; I don't believe this has ever worked. The "install name" for KArchive is different depending on whether we built with Qt5 or Qt6, so the install_name_tool command was only able to find/change the specified name in the Qt6 builds. This resulted in the legacy macOS qView being unable to load KRA/ORA files. I ran this fix through my Actions pipeline and can verify the names are correct in both cases now, e.g.:

otool -l kimg_kra-qt5.so | grep Archive
         name @rpath/libKF5Archive.5.dylib (offset 24)
otool -l kimg_kra-qt6.so | grep Archive
         name @rpath/libKF5Archive.5.dylib (offset 24)
         name @rpath/libKF5Archive.5.dylib (offset 24)

(Universal binary hence the two names in the Qt6 build).

By the way, this is a little test suite of images I gathered to test a lot (but not all) of the KImageFormats decoders. There's only one file in there you won't be able to open (.pxr) since the decoder is only in KDE Frameworks 6 (I updated my fork to that a while back; can PR eventually but probably not worth focusing on right now).

@jurplel jurplel merged commit b576d00 into jurplel:master Oct 16, 2024
12 checks passed
@jurplel
Copy link
Owner

jurplel commented Oct 16, 2024

Perfect, thank you!

@jdpurcell jdpurcell deleted the pr-legacykraora branch October 16, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants