-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows ARM64 #4
Conversation
@@ -15,6 +15,10 @@ if (-Not $IsWindows) { | |||
|
|||
# dependencies | |||
if ($IsWindows) { | |||
if ($env:buildArch -eq 'Arm64') { | |||
# CMake needs QT_HOST_PATH when cross-compiling | |||
$env:QT_HOST_PATH = [System.IO.Path]::GetFullPath("$env:QT_ROOT_DIR\..\$((Split-Path -Path $env:QT_ROOT_DIR -Leaf) -replace '_arm64', '_64')") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels dirty but I couldn't figure out a better way. I tried dumping all the environment variables on the runner via Write-Host but I didn't see any that point to the host Qt's folder. Maybe install-qt-action should be enhanced to set this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good suggestion for install-qt-action
, but this works.
There was a build failure on KImageFormats Win32 which should hopefully go away upon retry. I've had similar failures recently in my pipeline; the |
Re-running. Please remind me to take a look again tomorrow if I forget |
Looks like it built fine that time! I should mention, building EDIT: Turns out they later changed the workaround to apply for Visual Studio 2022 as well, but by checking for _MSC_VER < 1940. This was true up until Visual Studio 2022 version 17.9 (_MSC_VER=1939), but no longer as of Visual Studio 2022 version 17.10 (_MSC_VER=1940). I reported the bug to AOM's issue tracker. |
Right, that all makes sense. Nice work as always |
Adds job for Widows ARM64 w/ Qt 6.5.3. Had to update the runners to Windows 2022 as well due to one of the packages requiring Visual Studio 2022 to compile to ARM64.