Merge pull request #7 from fcollonval/fix-ci

Fix CI
jupyterlab-contrib · Jul 19, 2020 · 60e04a8 · 60e04a8
2 parents 10f9d9c + 876327b
commit 60e04a8
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 4 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -26,8 +26,8 @@ jobs:
         run: |
           jlpm
           cd test-jlab-toastify
+          jlpm install
           jlpm remove jupyterlab_toastify
           jlpm add file:${PWD}/..
-          jlpm build
           jupyter labextension install .
           python -m jupyterlab.browser_check
diff --git a/README.md b/README.md
@@ -75,6 +75,11 @@ The toast container will be added to the DOM automatically by `react-toastify`.
 
 ## Changelog
 
+### v4.1.0
+
+- Features
+  - Use SVG icons
+
 ### v4.0.0
 
 - Features

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "jupyterlab_toastify",
-  "version": "4.0.0",
+  "version": "4.1.0",
   "description": "Integrate 'react-toastify' nicely in JupyterLab.",
   "keywords": [
     "jupyter",

diff --git a/test-jlab-toastify/README.md b/test-jlab-toastify/README.md
@@ -2,4 +2,4 @@
 
 A dummy JupyterLab extension to test `jupyterlab-toastify`.
 
-> The package `jupyterlab-toastify` is installed through absolute path. That needs to be updated.
+> The package `jupyterlab-toastify` is installed through absolute path. It needs to be updated to test it locally.
diff --git a/test-jlab-toastify/package.json b/test-jlab-toastify/package.json
@@ -32,7 +32,7 @@
   },
   "dependencies": {
     "@jupyterlab/application": "^2.0.0",
-    "jupyterlab_toastify": "file:/home/fcollonval/jupyterlab_toastify/test-jlab-toastify/.."
+    "jupyterlab_toastify": "file:./.."
   },
   "devDependencies": {
     "@types/react": "^16.9.0",
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2,4 +2,4 @@

		A dummy JupyterLab extension to test `jupyterlab-toastify`.

		> The package `jupyterlab-toastify` is installed through absolute path. That needs to be updated.
		> The package `jupyterlab-toastify` is installed through absolute path. It needs to be updated to test it locally.