Add recommended chart labels alongside old labels (app.kubernetes.io/..., helm.sh/chart)
#3404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/modern-label-naming
branch
from
d40e580 to
0b44da9
Compare
4 tasks
This enables us to make a breaking change in z2jh 5 where user servers restarted once or more during z2jh 4 doesn't have to be restarted as part of the breaking change then. If we did it right away, network policy enforcement would fail for old servers for example. Before z2jh 4, we should also get kubespawner to specify `app.kubernetes.io/component` alongisde `component`. Also, its nice to be able to provide time for people to adjust to the new labels with a period of overlapping labels. For example, grafana dashboards working with prometheus metrics could keep working in this period and at any time transition to refering to new labels, and then when we get z2jh 5 released such dashboards could have already adjusted.
consideRatio
force-pushed
the
pr/modern-label-naming
branch
from
0b44da9 to
06114e0
Compare
consideRatio
changed the title
app.kubernetes.io/..., helm.sh/chart)
|
I think I understand what your intentions are.
|
consideRatio
force-pushed
the
pr/modern-label-naming
branch
3 times, most recently
from
d73782f to
5386112
Compare
consideRatio
force-pushed
the
pr/modern-label-naming
branch
from
944e3a7 to
2f8d0f8
Compare
|
Done @manics - I also fixed unrelated test failures via jupyterhub/action-k3s-helm#116, |
Co-authored-by: Simon Li <[email protected]>
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
May 8, 2024
jupyterhub/zero-to-jupyterhub-k8s#3404 Merge pull request #3404 from consideRatio/pr/modern-label-naming
|
Thank you for reviewing @manics!!! ❤️ 🎉 🌻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables us to make a breaking change in z2jh 5 where user servers restarted once or more during z2jh 4 doesn't have to be restarted as part of the breaking change then. If we did it right away, network policy enforcement would fail for old servers for example.
Before z2jh 4, we should also get kubespawner to specify
app.kubernetes.io/componentalongisdecomponent. This is done in jupyterhub/kubespawner#835.Also, its nice to be able to provide time for people to adjust to the new labels with a period of overlapping labels. For example, grafana dashboards working with prometheus metrics could keep working in this period and at any time transition to refering to new labels, and then when we get z2jh 5 released such dashboards could have already adjusted.