Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally set resourceLock to prevent chart incompatibilities with 1.27+ binary of kube-scheduler #3291

Conversation

VariableExp0rt
Copy link

@VariableExp0rt VariableExp0rt commented Dec 4, 2023

This PR aims to prevent an issue with the installation of the Chart with a kube-scheduler version that removes the endpointsleases resource lock (which is in 1.27+), which is the current default in the Chart. For reference, the resource lock can only be leases as referenced here https://github.com/kubernetes/kubernetes/blob/v1.27.0/pkg/scheduler/apis/config/validation/validation.go#L48, otherwise this function errors.

…h 1.27+

Signed-off-by: liam.baker <liam.baker@sage.com>
Copy link

welcome bot commented Dec 4, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@consideRatio
Copy link
Member

I never understood the issue fully here, because tests make this work on 1.27 as it is.

#3312 is a pr that does this change as part of upgrading to use a kube-scueduler binary from k8s 1.28, and then this change is required i think.

@consideRatio consideRatio changed the title Conditionally set resourceLock to prevent chart incompatibilities with 1.27+ Conditionally set resourceLock to prevent chart incompatibilities with 1.27+ binary of kube-scheduler Jan 12, 2024
@consideRatio
Copy link
Member

This is resolved by #3312, where the kube-scheduler binary from k8s 1.28 will be used instead of the one from k8s 1.26.

I understand now that the key thing to check in this PR wasn't the k8s clusters k8s version, but the configured kube-scheduler binary we use. The configuration is hardcoded to work with the configured kube-scheduler binary, so if we want to support other kube-scheduler binary versions, we should check against that as compared to the k8s clusters version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants