Allow deployments to get custom labels from values.yaml

[sam-som]

Proposed change

• Allow custom labels from values.yaml to be applied to deployments. Currently these custom labels are only added at the pods level and not at the deployments level
  • hub
  • proxy
  • proxy -> autohttps
  • user-scheduler

Who would use this feature?

• User who would like to apply custom labels to the deployments (and not just the pods)
• Example usage: We are adding OPA to our k8s, but we currently cannot enforce required-labels for jupyterhub deployments

(Optional): Suggest a solution

• [WIP] Added labels to deployments #2948
  • Still need testing and fixing failing test

[welcome]

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.

You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[consideRatio]

Hey @sam-som!

Could you try to:

• provide a practical example of labels you want to set on your deployment resources?
• clarify if you think it makes for the labels you set to be the same or separate from the labels you set on the pod templates?

I don't know much about OPA, but I assume it allows for various rules to be defined and enforced. It would be relevant to understand what kind of rule enforcement makes you need to set labels on the deployment resources as well.

[sam-som]

Hi @consideRatio
Thank you for your quick response

• For our use case, we are implementing enforcement in OPA that requires all deployments in all our clusters to have 2 labels (team: <team-name> and env: <dev|staging|prod>). This enforcement would allow us to do audits, cost analysis, and establish ownership of resources in the clusters.
• In my opinion (and our use case), it makes sense for pods and their deployment to have the same set of labels

[sam-som]

Hi @consideRatio 👋
I want to follow up on this issue
If we want to go forward with this, i can get the PR into mergeable state