Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all resources support annotations configuration #3054

Closed
dev-dsp opened this issue Mar 9, 2023 · 4 comments
Closed

Not all resources support annotations configuration #3054

dev-dsp opened this issue Mar 9, 2023 · 4 comments

Comments

@dev-dsp
Copy link

dev-dsp commented Mar 9, 2023

Proposed change

Introduce annotations in Hub & CHP Deployment

Alternative options

Introduce global extraAnnotations for all possible generated resources

Who would use this feature?

Would be useful for different k8s management solutions that use annotations for searching resources.

@welcome
Copy link

welcome bot commented Mar 9, 2023

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@manics
Copy link
Member

manics commented Mar 9, 2023

The hub and proxy already support annotations:

What additional functionality do you need?

@dev-dsp
Copy link
Author

dev-dsp commented Mar 9, 2023

@manics
Copy link
Member

manics commented Mar 12, 2023

Thanks for elaborating. Please follow this existing issue #2949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants