Skip to content

Commit

Permalink
fix: use extraPaths instead of customPaths to keep coherence with pro…
Browse files Browse the repository at this point in the history
…perties naming convention; add URL to the kubernetes doc so user can find examples to build the extraPaths list
  • Loading branch information
alexis-giorkallos-al committed Sep 9, 2024
1 parent 03c86bc commit 75c1ae7
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion jupyterhub/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ spec:
name: {{ include "jupyterhub.proxy-public.fullname" $ }}
port:
name: http
{{- range $path := $.Values.ingress.customPaths }}
{{- range $path := $.Values.ingress.extraPaths }}
- path: {{ $path.path }}
pathType: {{ $path.pathType }}
backend:
Expand Down
5 changes: 4 additions & 1 deletion jupyterhub/values.schema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2757,13 +2757,16 @@ properties:
See [the Kubernetes
documentation](https://kubernetes.io/docs/concepts/services-networking/ingress/#tls)
for more details about annotations.
customPaths:
extraPaths:
type: array
description: |
A list of custom paths to be added to the ingress configuration.
Each custom path allows traffic to be routed to a specific backend service.
For each path, you can specify the service name, and either a service port number or a service port name.
See [the Kubernetes documentation](https://kubernetes.io/docs/concepts/services-networking/ingress/#path-types)
for more details about paths.
prePuller:
type: object
additionalProperties: false
Expand Down
2 changes: 1 addition & 1 deletion jupyterhub/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -695,7 +695,7 @@ ingress:
pathSuffix:
pathType: Prefix
tls: []
customPaths: []
extraPaths: []

# cull relates to the jupyterhub-idle-culler service, responsible for evicting
# inactive singleuser pods.
Expand Down

0 comments on commit 75c1ae7

Please sign in to comment.