Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test python 3.12, redis 7, traefik 3 - and misc updates to align with jupyterhub-python-repo-template #231

Merged
merged 14 commits into from
Jan 26, 2024
Merged

Test python 3.12, redis 7, traefik 3 - and misc updates to align with jupyterhub-python-repo-template #231

merged 14 commits into from
Jan 26, 2024

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Jan 24, 2024 •
edited
Loading

  • adds tests for py312, redis 7 and traefik 3. A total of two test cases are added, from 4 to 6
  • refreshes readthedocs config
  • refreshes release.yaml workflow and RELEASE.md based on jupyterhub-python-repo-template
  • fixes use of deprecated use of codecov package
  • puts pytest config in pyproject.toml
  • cleanup black from dev-requirements.txt
  • clarifies when ETCDCTL_API need to be set
  • adds docstring fix suggested by @GeorgianaElena in add redis implementation #230 (comment)
  • replaces use of dev-requirements.txt with pip install .[test] behavior

@consideRatio consideRatio force-pushed the pr/test-traefik branch 4 times, most recently from 9fc8d4a to 8e53423 Compare January 24, 2024 23:14
minrk
minrk reviewed Jan 25, 2024
View reviewed changes
@minrk minrk added maintenance api-change breaking changes and removed api-change breaking changes labels Jan 25, 2024
@consideRatio consideRatio force-pushed the pr/test-traefik branch 2 times, most recently from f1c5dc8 to f68305e Compare January 25, 2024 10:29
@consideRatio consideRatio mentioned this pull request Jan 25, 2024
Merged
5 tasks
@consideRatio consideRatio force-pushed the pr/test-traefik branch 3 times, most recently from 89f1678 to 0514d80 Compare January 25, 2024 11:03
@consideRatio consideRatio changed the title Test python 3.12 and traefik 3.0.0-beta5 and misc stuff Test python 3.12, redis 7, traefik 3, and misc Jan 25, 2024
@consideRatio consideRatio force-pushed the pr/test-traefik branch 5 times, most recently from a600ae3 to b15679d Compare January 25, 2024 13:16
@consideRatio consideRatio changed the title Test python 3.12, redis 7, traefik 3, and misc Test python 3.12, redis 7, traefik 3 - and misc updates to align with jupyterhub-python-repo-template Jan 25, 2024
@consideRatio consideRatio marked this pull request as ready for review January 25, 2024 13:26
minrk
minrk approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@minrk minrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

minrk
minrk reviewed Jan 25, 2024
View reviewed changes
GeorgianaElena
GeorgianaElena approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thank you @consideRatio!

@consideRatio
Copy link
Member Author

Thank you for reviewing @minrk and @GeorgianaElena!!! I pushed two commits that I don't consider merits additional review, so I'm going for a merge.

@consideRatio consideRatio merged commit 0388783 into jupyterhub:main Jan 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minrk minrk minrk approved these changes

@GeorgianaElena GeorgianaElena GeorgianaElena approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@consideRatio @minrk @GeorgianaElena