-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changelog for 1.0 #176
changelog for 1.0 #176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that this repo is back up to date is it worth going for a 1.0.0 prerelease instead?
Co-authored-by: Simon Li <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm +1 on making a release now.
Now that this repo is back up to date is it worth going for a 1.0.0 prerelease instead?
I also think that a 1.0.0 prerelease makes sense given the latest changes?
Maybe? I think we're still learning about traefik, so I'd feel slightly more comfortable with 0.4 for now. On the other hand, it's been used in TLJH for ages without apparent issue. WDYT @GeorgianaElena? I think reasons to maybe consider it not quite ready for 1.0 are:
At the same time, I'm generally for the idea that the bar for 1.0 should be "people use this," which is clearly the case for us already. |
Since you're both for 1.0, I updated it to 1.0. I think we're ready for a beta! |
FWIW, should we put a deprecation on consul already, as discussed in #155 ? |
I believe that deprecating it now that we're going for a 1.0 release makes sense. |
Do you envisage any breaking changes for #170 ? That would be a good reason not to go for 1.0.0. |
I don't think so - it should mainly be rewriting a private method or two that exist now into calling other slightly more generic methods. I guess it would make the new generic methods reuqired for KV subclasses, but those don't exist outside this package, so I'm not worried about that. |
Actually, looking at #170, I think it will probably be a pretty significant reorganization. It shouldn't be public-facing, though. |
# Conflicts: # docs/source/changelog.md
OK, updated with the latest PRs. Ready for 1.0b1! |
@GeorgianaElena I think we can make an 0.4.0b1 with this as it is and start asking folks to test it. WDYT?