Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance, scaling #165

Merged
merged 5 commits into from
Mar 10, 2023
Merged

Improve performance, scaling #165

merged 5 commits into from
Mar 10, 2023

Conversation

minrk
Copy link
Member

@minrk minrk commented Mar 3, 2023 •
edited
Loading

  • limit concurrency of API requests, fixes timeouts running perf tests
  • check for specific endpoints with traefik API instead of getting them all
  • reduce exponential-backoff scale factor for slightly quicker retries
  • add traefik_providers_throttle_duration to set traefik.providersThrottleDuration, and set the default to 0s for maximum responsiveness, which drastically improves perceived performance

@minrk minrk requested a review from GeorgianaElena March 3, 2023 13:46
@minrk
Copy link
Member Author

minrk commented Mar 3, 2023

I thought 2 minutes was too fast. Will rebase after #167 so that tests actually run

@minrk minrk mentioned this pull request Mar 3, 2023
Merged
@minrk minrk added the enhancement New feature or request label Mar 3, 2023
minrk added 4 commits March 6, 2023 11:25
@minrk
Limit concurrency of API requests
823480c 
and check for specific endpoints instead of getting everything, which gets expensive
@minrk
isntead of queuing get_all, piggy-back
92672dd 
same limit on the number of outstanding calls, but bunches results instead of starting an ever-growing queue
@minrk
reduce scale factor on traefik wait
cf93289 
increases responsiveness
@minrk
add traefik_providers_throttle_duration config and set to 0 by default
11d3157 
and set a default of 100ms

unlike a general purpose use case, we want routes to be reflected immediately
@minrk
Copy link
Member Author

minrk commented Mar 6, 2023

@GeorgianaElena now ready for review. This reduces our test runtime by about 1/3.

GeorgianaElena
GeorgianaElena approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 🎉

@minrk minrk merged commit f2e3d4b into jupyterhub:main Mar 10, 2023
@minrk minrk deleted the tweak-perf branch March 10, 2023 14:22
@minrk
Copy link
Member Author

minrk commented Mar 10, 2023

Thanks @GeorgianaElena!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgianaElena GeorgianaElena GeorgianaElena approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minrk @GeorgianaElena