-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit config and configure autoformating tools and pytest from pyproject.toml #157
Conversation
ea3f0e5
to
27768cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'd say we should hold off merging this a bit until other open PRs get merged to avoid merge conflicts.
I see pre-commit.ci is already configured to run for this repo at #156 now btw, so the work for this PR can be as simple as git checkout main
, git pull
, git checkout autoformatting
, git rebase -i main
and then delete the pick <commit that ran pre-commit>
, git push --force
I mared this as draft to signal its good to go - but pending.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One little comment about excluding versioneer's file from autoformatters (feel free to switch to tbump instead, if you want), but should be ready now
27768cf
to
156f93c
Compare
`c = get_config() # noqa` fixes lint errors
156f93c
to
f45dc97
Compare
No description provided.