Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit config and configure autoformating tools and pytest from pyproject.toml #157

Merged
merged 7 commits into from
Feb 23, 2023

Conversation

GeorgianaElena
Copy link
Member

No description provided.

Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd say we should hold off merging this a bit until other open PRs get merged to avoid merge conflicts.

I see pre-commit.ci is already configured to run for this repo at #156 now btw, so the work for this PR can be as simple as git checkout main, git pull, git checkout autoformatting, git rebase -i main and then delete the pick <commit that ran pre-commit>, git push --force

I mared this as draft to signal its good to go - but pending.

@consideRatio consideRatio marked this pull request as draft February 21, 2023 20:13
Copy link
Member

@minrk minrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little comment about excluding versioneer's file from autoformatters (feel free to switch to tbump instead, if you want), but should be ready now

jupyterhub_traefik_proxy/_version.py Outdated Show resolved Hide resolved
@GeorgianaElena GeorgianaElena marked this pull request as ready for review February 23, 2023 09:46
@minrk minrk merged commit 6d0dfaf into jupyterhub:main Feb 23, 2023
@GeorgianaElena GeorgianaElena deleted the autoformatting branch February 23, 2023 10:47
@minrk minrk mentioned this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants